Products: Draft product preview (WIP) #7878
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealeksandrov
added
feature: product details
Collaborator
You can test the changes from this Pull Request by:
|
Contributor
Author
|
Closing in favor of #7960 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a draft of "product preview" functionality.
It adds "preview" option in action sheet on product form. It appears for new product flow and existing drafts.
On button tap it saves the product as a draft and opens URL in SafariVC.
Known issue: because session in SafariVC is not authenticated, preview links for drafts can't be directly accessed at this time. Links work when opened in previously authenticated Safari.
Video
Simulator.Screen.Recording.mp4
RELEASE-NOTES.txtif necessary.